Frog CMS

Fixed: Custom “page not found” conflict with Image Resize

Replace the existing code for page_not_found (index.php):

function behavior_page_not_found()
{
    global $__FROG_CONN__;

	/*
	 *	added: test for valid image_resize request; code block copied and modified from image_resize
	 */
	$path = ltrim($_SERVER['QUERY_STRING'],'QS=');
	$params      = explode("/", $path);
	$namepart    = array_pop($params);
	$isValidResize = false;
    if (preg_match('#(.+)\.([0-9]+)x?(c?)\.([a-z]+)$#i', $namepart, $match)) {
		$isValidResize = true;
    } else if (preg_match('#(.+)\.x([0-9]+)(c?)\.([a-z]+)$#i', $namepart, $match)) {
		$isValidResize = true;
    } else if (preg_match('#(.+)\.([0-9]+)x([0-9]+)(c?)\.([a-z]+)$#i', $namepart, $match)) {
		$isValidResize = true;
    }

	/*
	 * if following condition not met, then allow the image_resize observer to kick-in
	 */
    if (!preg_match('#^.+\.(jpg|jpeg|gif|png)$#i', $path) || !$isValidResize) {
		/*
		 * No request for resizing image; resolve original request for page_not_found
		 */
		$sql = 'SELECT * FROM '.TABLE_PREFIX."page WHERE behavior_id='page_not_found'";
		$stmt = $__FROG_CONN__->prepare($sql);
		$stmt->execute();

		if ($page = $stmt->fetchObject())
		{
			$page = find_page_by_uri($page->slug);

			// if we fund it, display it!
			if (is_object($page))
			{
				header("HTTP/1.0 404 Not Found");
				header("Status: 404 Not Found");

				$page->_executeLayout();
				exit(); // need to exit here otherwise the true error page will be sended
			}
		}
	}
}

Basically, we test if we have a valid image_resize request, if we don’t then we pass control onto the custom page_not_found handler.

The above patch for image_resize plugin will not work in future versions of Frog. Currently on SVN there is a change of how FrogCMS deals with $_GET variables, and there isn’t a QS variable anymore in last SVN version of FrogCMS, it was changed to PAGE. In order to be sure that the plugin will work in future versions of Frog use a predefined constant CURRENT_URI instead of using a query string and stripping a QS= from it.

Change to:

$path = CURRENT_URI;

Fixed: Custom “page not found” conflict with Image Resize
Replace the existing code for page_not_found (index.php):

This code is for page_not_found plugin not image_resize plugin. IMO the conflict should be resolved in image_resize.

If the page_not_found plugin is the first one to intercept the 404 condition, then the image_resize request would never get triggered regardless of a (non-)existing image is resized or not.

Basically, do we need some rules to be defined to dictate the processing order of Observer events?

I’m not yet familiar with how the “Observer” works nor how it gives priority to plugins hooking into the Observer controller. But from what I understand, it looks like it’s stacking the requests.

Therefore the fix in image_resize is only one half of the overall problem …. or am I confusing things somewhat?

@scoot3r – the observer system does not work with priorities. Basically you’re trying to override the page_not_found plugin when a page can’t be found… either don’t use the page_not_found plugin or add a little php code to the custom page_not_found page that activates the image_resize plugin?

prioritizing events will make the system prohibitively complex.

In order to be sure that the plugin will work in future versions of Frog use a predefined constant CURRENT_URI instead of using a query string and stripping a QS= from it.

BTW. It should be noted that CURRENT_URI is the URL without URL_SUFFIX. This might lead to some confusions.

@davidhund
I have a similar problem with the Image Resize plugin alone. Maybe this could help you..

“imagecreatefromjpeg” function is not defined in my server (even if GD is installed) and so jpg files are not saved. “imagecreatefromgif” and “imagecreatefrompng” work fine.

Try to make a blank page with this code:

<?php imagecreatefromjpeg(); ?>

and see what happens.
Maybe you have to contact your sys admin to fix the problem!

Excellent. I was playing with similar idea but instead writing a warning to flash after installing.

Excellent stuff again. Big thanks to Kirok!